ci: remove the danger-review job

Kai Armstrongrequested to merge
ci/remove-danger-review into main

What does this MR do?

Removes the danger-review CI/CD component include, the Dangerfile, and the now-unused Dangerfile entry in .code-patterns. Rewrites the "Who reviews the changes?" section of the development process docs.

Why?

The job only produced a reviewer suggestion. The Dangerfile imported a single rule:

dangerfiles.import_dangerfiles(only: %w[simple_roulette])

So the entire output of a run was the "Reviewer roulette" comment with a reviewer/maintainer table, ending in:

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

It enforced nothing: no changelog, commit, or docs checks. The author still had to assign by hand. On fork MRs it doesn't even post, because the component runs Danger in dry-run mode when CI_MERGE_REQUEST_PROJECT_URL != CI_MERGE_REQUEST_SOURCE_PROJECT_URL, so community contributions never saw the comment in the first place.

The Recommend Reviewers flow already does this, and actually assigns. The project has reviewer_assignment_strategy = dap_powered, so the Recommend Reviewers flow assigns the smallest set of reviewers that satisfies each approval rule when an MR is marked ready, accounting for availability, workload, and time zone. It is demonstrably working: every recent MR has a human reviewer assigned alongside @GitLabDuo, including MRs opened by bots.

Keeping both means two mechanisms proposing reviewers, where only one of them does anything.

How to verify

  • glab ci lint passes.
  • No references to Danger remain: grep -rn "Dangerfile\|danger" --include="*.yml" --include="*.md" --include="*.go" . returns nothing related.
  • After merge, MR pipelines should have no danger-review job, and newly-ready MRs should still get reviewers assigned by the flow.

Note for the reviewer

The docs change swaps the roulette paragraph for a description of the flow. Worth a read to confirm it matches how the team actually expects reviewer assignment to work now, since docs/development_process.md is the page contributors land on.

🤖 Generated with Claude Code

Merge request reports