feat: rotate personal, project or group access tokens
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
Description
Add support for rotating personal, project and group access tokens.
Related Issues
Supplements #980 (closed)
How has this been tested?
unit tests were added and all commands were tested manually. I do not have a private installation of gitlab, so I could not test the creation of personal access tokens for other users.
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change) -
Documentation -
Chore (Related to CI or Packaging to platforms) -
Test gap
Merge request reports
Activity
Thanks for your contribution to GitLab @mvanholsteijn!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, comment
@gitlab-bot helpor come say hi on Discord. - When you're ready for a review, comment on this merge request with
@gitlab-bot ready. - Tip: Start @gitlab-bot commands at the beginning of a new comment and do not wrap the command in quotes or backticks.
- We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
This message was generated automatically. You're welcome to improve it.
- If you need help, comment
added 1st contribution Community contribution workflowin dev labels
assigned to @mvanholsteijn
added linked-issue label
mentioned in merge request !1583 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19355 (closed)
added featureaddition groupcode review labels
added typefeature label
added devopscreate sectiondev labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @amknight(UTC-4)
@jay_mccure(UTC+10)
Generated by
- Resolved by Kai Armstrong
@truegreg Given this touches on tokens, would you mind doing an appsec review?
- Last reply by Kai Armstrong
- Resolved by Mark van Holsteijn
@amknight Do you have capacity to review this or should we find someone else?
- Last reply by Kai Armstrong
requested review from @jay_mccure and removed review request for @amknight
Hi @mvanholsteijn thanks for contributing all these additional features for
tokens
As per !1583 (comment 2073824411) I have made this MR dependant on !1640 (merged) & !1641 (merged) and will review once they are merged
added 16 commits
- 778f8c36...64104902 - 6 earlier commits
- 385dae7b - chore: Apply 1 suggestion(s) to 1 file(s)
- 1252e7f7 - chore: regenerated the documentation
- 76df3708 - Merge branch 'feat/token-support-step-1-create' into feat/token-support-step-2-revoke
- 0d93bf06 - chore: user messages changed according the edits of @aqualls
- b5c4ea1f - chore: json output unformatted
- 8dac6910 - chore: generated docs
- 96cd6188 - chore: changed alias from tok to token as suggested by @jamesliu-gitlab
- 602d8bde - chore: make gen-docs
- dec16265 - Merge branch 'feat/token-support-step-2-revoke' into origin/feat/token-support-step-3-rotate
- cf58f5a7 - chore: user messages changed according the edits of @aqualls
Toggle commit listmentioned in merge request !1642 (merged)
please merge after !1641 (merged)
added 6 commits
- c20b568c - fix: time.Duration parses only hours
- f3c047be - Merge branch 'feat/token-support-step-1-create' into feat/token-support-step-2-revoke
- 8e7950d6 - Merge branch 'feat/token-support-step-2-revoke' into origin/feat/token-support-step-3-rotate
- 5665d905 - fix: time.Duration parses only hours
- ad6b428c - refactor: remove unused function CreateAccessLevelFromString
- 5573d957 - Merge branch 'feat/token-support-step-2-revoke' into origin/feat/token-support-step-3-rotate
Toggle commit listadded 55 commits
-
2d3cffec...4e1597be - 53 commits from branch
gitlab-org:main - bc1bd0a6 - Merge branch 'org-main' into feat/token-support-step-2-revoke
- 2f3539ad - Merge branch 'feat/token-support-step-2-revoke' into origin/feat/token-support-step-3-rotate
-
2d3cffec...4e1597be - 53 commits from branch
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
-
Hi
@aqualls! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it. added documentation twtriaged labels
requested review from @aqualls
-
@aqualls @truegreg @jay_mccure, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
added Technical Writing label
mentioned in merge request !1641 (merged)
added 5 commits
Toggle commit list- Resolved by Mark van Holsteijn
@gitlab-bot ready
- Last reply by Mark van Holsteijn
added 42 commits
-
26bb72ec...e8951334 - 41 commits from branch
gitlab-org:main - b14da735 - Merge branch 'org-main' into feat/token-support-step-3-rotate
-
26bb72ec...e8951334 - 41 commits from branch
@gitlab-bot ready
added 3 commits
-
b14da735...637e9ce1 - 2 commits from branch
gitlab-org:main - 50b38042 - Merge branch 'org-main' into feat/token-support-step-3-rotate
-
b14da735...637e9ce1 - 2 commits from branch
@gitlab-bot ready
- Resolved by Mark van Holsteijn
This looks great, thanks @mvanholsteijn - just one small suggestion/question when you have a moment.
- Last reply by Jay McCure
requested review from @jay_mccure
@gitlab-bot ready
@gitlab-bot ready
-
Great work @mvanholsteijn, thank you so much for this contribution
started a merge train
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @amknight@jay_mccureGenerated by
mentioned in commit 470df3b4
-
@mvanholsteijn, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
- Create a new comment starting with
@gitlab-bot feedbackbelow, and leave any additional feedback you have for us in the comment.
As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo. With Code Suggestions, Chat and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code. Visit the Duo access project to request a GitLab Duo license and learn more about the benefits of GitLab Duo.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
Thank you @jay_mccure, @aqualls and @truegreg! So nice!!
-
Anytime @mvanholsteijn! Thank you for your contribution.
-
Thank you @mvanholsteijn, much appreciated
