Skip to content

fix: always stop spinner to avoid to mess up the terminal

Denys Vitali requested to merge denysvitali_niantic/cli:fix/spinner into main
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

Description

Before this MR, the spinner in glab stack sync was never cleaned up correctly in case of error in the process. This caused the terminal to be in weird states (e.g: no cursor) that one could only recover from by using reset.

With this MR we fix the problem by always stopping the spinner - independently from the process result.

Related Issues

N/A

How has this been tested?

N/A

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Denys Vitali

Merge request reports