Skip to content

fix: allow listening hostname to be provided

Ash McKenzie requested to merge ashmckenzie/fix-macos-listen-popup into main

Description

This small MR fix ensures the listening hostname for the OAuth 2 HTTP handlers can be provided, which for testing, means we can pass in localhost which removes the macOS popup from appearing.

cc @jay_mccure

Related Issues

N/A

How has this been tested?

To replicate, clone the project, checkout main and run make test to see the macOS popup. Check out this branch (ashmckenzie/fix-macos-listen-popup) and re-run make test to observe the popup no longer appears.

Screenshots (if appropriate):

image__3_

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Ash McKenzie

Merge request reports