Skip to content

chore(dependency): remove alecthomas/assert module

Jay McCure requested to merge jmc-7292 into main

Description

Remove dependency alecthomas/assert https://github.com/alecthomas/assert/tree/v1 (118 stars) and replace with the other assertion library being used within this project (and more widely used): github.com/stretchr/testify/assert https://github.com/stretchr/testify (20K stars)

28 test files were using alecthomas/assert whereas github.com/stretchr/testify/assert is being used in the other files ( approximately 80 )

alecthomas/assert is a fork of testify/require so the function signatures are the same. The reason for the fork is explained here: https://github.com/alecthomas/assert/tree/v1#go-assertion-library-fork-of-stretchrtestifyrequire, but I think using one assertion library across this project will be better for future maintenance.

Related Issues

Resolves #7292 (closed)

How has this been tested?

make test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Jay McCure

Merge request reports