Skip to content

chore: use latest tview version

Jay McCure requested to merge jmc-upgrade-tview into main

Description

With this bug fix in tview https://github.com/rivo/tview/pull/757 / https://github.com/rivo/tview/commit/c59dc10ace874313ce9fa678f5e47629ad9181ff it seems to have fixed having to initialise the screen explicitly. It looks like we were working around this, so to upgrade we need to stop initialising the screen.

Without this fix, when using the latest version of tview, a blank screen would hang when doing the below commands.

Related Issues

Resolves #3763 (closed)

How has this been tested?

Using https://gitlab.com/gitlab-org/cli on main

  • glab ci view

  • can view latest pipeline

  • Screenshot_2023-08-05_at_12.56.09

  • glab issue board view

  • select > Development (PROJECT: cli)

  • Screenshot_2023-08-05_at_12.59.49

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Jay McCure

Merge request reports