Skip to content

fix: do not enforce argument for 'ci delete' when using filter

Sebastian Krebs requested to merge (removed):bugfix/ci-delete-no-argument-when-using-option into main

Description

When executing glab ci delete --status=failed the command fails, because it expects an argument. Adding an completely unused fake argument would execute the command, but thats strange.

The MR makes the command glab ci delete --status 1234 fail with an error, that no argument is expected.

Please somebody decide: Technically this is a breaking change, because now every usage (script, pipeline, ..), which uses glab ci delete --status=$STATUS fake will fail. However, this is actually a more like a hack to get it somehow running. I marked the "non-breaking bugfix" checkbox now.

Related Issues

Resolves #1306 (closed)

How has this been tested?

Three test cases were added

  • ci delete --status (does not fail)
  • ci delete --status <argument> (fails: no argument expected)
  • ci delete (fails: Argument missing)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap

Merge request reports