Skip to content

build(deps): upgrade github.com/xanzy/go-gitlab to v0.73.1

Oscar Tovar requested to merge upgrade-go-gitlab-dependency into main

Description

This MR upgrades the github.com/xanzy/go-gitlab dependency to v0.73.1. This upgrade had many breaking changes that required updating existing function calls. The motivation for this MR comes from !1033 (comment 1108005251).

Related Issues

See !1033 (comment 1108005251) for more context.

How has this been tested?

Ran the tests locally and updated the expectations to match the functions that now return pointers.

Click to expand
make test
Skip this
gotestsum --no-summary=skipped --junitfile ./coverage.xml --format short -- -coverprofile=./coverage.txt -covermode=atomic  ./pkg/... ./internal/... ./commands/... ./cmd/...
✓  pkg/browser (103ms) (coverage: 54.5% of statements)
✓  pkg/execext (151ms) (coverage: 100.0% of statements)
✓  pkg/tableprinter (171ms) (coverage: 82.8% of statements)
✓  pkg/text (194ms) (coverage: 100.0% of statements)
✓  pkg/git (272ms) (coverage: 46.8% of statements)
✓  pkg/glinstance (275ms) (coverage: 95.0% of statements)
∅  pkg/httpmock
✓  pkg/iostreams (323ms) (coverage: 26.5% of statements)
∅  pkg/prompt
∅  pkg/surveyext
✓  internal/config (389ms) (coverage: 47.5% of statements)
✓  pkg/utils (388ms) (coverage: 51.7% of statements)
✓  commands/alias/expand (159ms) (coverage: 45.1% of statements)
✓  internal/glrepo (362ms) (coverage: 94.8% of statements)
✓  commands/auth/authutils (116ms) (coverage: 14.6% of statements)
∅  internal/run
✓  commands/alias/delete (364ms) (coverage: 82.6% of statements)
✓  commands/alias (466ms) (coverage: 100.0% of statements)
✓  commands/alias/set (549ms) (coverage: 88.1% of statements)
✓  commands/alias/list (606ms) (coverage: 88.5% of statements)
✓  commands/api (709ms) (coverage: 83.5% of statements)
✓  commands/auth (768ms) (coverage: 100.0% of statements)
✓  commands/auth/status (781ms) (coverage: 94.0% of statements)
✓  commands/ci (776ms) (coverage: 100.0% of statements)
✓  commands/ci/legacyci (561ms) (coverage: 100.0% of statements)
✓  commands/completion (360ms) (coverage: 88.2% of statements)
✓  commands/ci/view (459ms) (coverage: 50.9% of statements)
✓  commands (2.146s) (coverage: 68.0% of statements)
✓  commands/help (275ms) (coverage: 67.3% of statements)
✓  commands/cmdutils (459ms) (coverage: 60.2% of statements)
✓  commands/config (545ms) (coverage: 39.4% of statements)
✓  commands/issue (395ms) (coverage: 100.0% of statements)
✓  commands/issue/board (455ms) (coverage: 100.0% of statements)
✓  commands/issue/board/create (432ms) (coverage: 80.0% of statements)
✓  commands/auth/login (2.636s) (coverage: 49.2% of statements)
∅  commands/ci/artifact
∅  commands/ci/ciutils
∅  commands/ci/delete
✓  commands/issue/list (522ms) (coverage: 77.0% of statements)
✓  commands/issue/create (1.022s) (coverage: 38.6% of statements)
✓  commands/issue/note (672ms) (coverage: 95.2% of statements)
✓  commands/issue/close (1.648s) (coverage: 90.0% of statements)
✓  commands/issue/subscribe (1.257s) (coverage: 88.9% of statements)
✓  commands/issue/unsubscribe (1.209s) (coverage: 88.9% of statements)
✓  commands/label (387ms) (coverage: 100.0% of statements)
✓  commands/issue/delete (1.73s) (coverage: 88.9% of statements)
✓  commands/mr/create (303ms) (coverage: 41.4% of statements)
✓  commands/issue/update (1.597s) (coverage: 58.9% of statements)
✓  commands/ci/lint (4.604s) (coverage: 75.0% of statements)
∅  commands/ci/list
∅  commands/ci/retry
∅  commands/ci/run
∅  commands/ci/status
✓  commands/mr/list (451ms) (coverage: 72.6% of statements)
✓  commands/mr/diff (544ms) (coverage: 90.2% of statements)
✓  commands/mr/mrutils (495ms) (coverage: 69.4% of statements)
✓  commands/issue/view (2.045s) (coverage: 90.7% of statements)
✓  commands/mr (2.043s) (coverage: 100.0% of statements)
✓  commands/project (378ms) (coverage: 100.0% of statements)
✓  commands/mr/delete (2.522s) (coverage: 86.7% of statements)
✓  commands/mr/note (2.1s) (coverage: 94.7% of statements)
✓  commands/project/create (182ms) (coverage: 0.0% of statements)
✓  commands/mr/subscribe (2.573s) (coverage: 85.0% of statements)
✓  commands/release (285ms) (coverage: 100.0% of statements)
✓  commands/release/list (437ms) (coverage: 84.1% of statements)
✓  commands/mr/unsubscribe (2.562s) (coverage: 85.0% of statements)
✓  commands/mr/update (2.495s) (coverage: 46.9% of statements)
✓  commands/snippet (406ms) (coverage: 100.0% of statements)
✓  commands/update (386ms) (coverage: 84.8% of statements)
✓  commands/user (269ms) (coverage: 100.0% of statements)
✓  commands/variable (394ms) (coverage: 100.0% of statements)
✓  commands/variable/get (385ms) (coverage: 72.7% of statements)
✓  commands/mr/view (3.18s) (coverage: 84.7% of statements)
✓  commands/variable/delete (596ms) (coverage: 81.6% of statements)
✓  commands/project/clone (3.077s) (coverage: 73.7% of statements)
✓  commands/variable/set (1.275s) (coverage: 84.9% of statements)
✓  commands/variable/update (1.142s) (coverage: 84.6% of statements)
✓  commands/version (1.515s) (coverage: 100.0% of statements)
✓  commands/variable/variableutils (1.655s) (coverage: 80.0% of statements)
✓  cmd/glab (1.416s) (coverage: 59.2% of statements)
✓  commands/project/archive (5.094s) (coverage: 0.0% of statements)
✓  commands/ci/trace (16.088s) (coverage: 63.2% of statements)
∅  commands/cmdtest
∅  commands/issue/board/view
∅  commands/issue/issueutils
∅  commands/issue/reopen
∅  commands/label/create
∅  commands/label/list
∅  commands/mr/approve
∅  commands/mr/approvers
∅  commands/mr/checkout
∅  commands/mr/close
∅  commands/mr/for
∅  commands/mr/issues
∅  commands/mr/merge
∅  commands/mr/rebase
∅  commands/mr/reopen
∅  commands/mr/revoke
∅  commands/mr/todo
∅  commands/project/contributors
∅  commands/project/delete
∅  commands/project/fork
∅  commands/project/list
∅  commands/project/mirror
∅  commands/project/search
∅  commands/project/transfer
∅  commands/project/view
∅  commands/release/create
∅  commands/release/delete
∅  commands/release/download
∅  commands/release/releaseutils
∅  commands/release/releaseutils/upload
∅  commands/release/upload
∅  commands/release/view
∅  commands/snippet/create
∅  commands/ssh-key
∅  commands/ssh-key/add
∅  commands/ssh-key/get
∅  commands/ssh-key/list
∅  commands/user/events
∅  commands/variable/list
∅  cmd/gen-docs

DONE 937 tests in 18.820s

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

Merge request reports