Skip to content

Ansible code simplifications

Adrien Kohlbecker requested to merge ak/user into master

What does this MR do?

Each commit in this MR is individually reviewable

In !60 (merged) I merged two users into one. Since we now have only one user, we can skip all the custom user variables (asdf_user, homebrew_user, ci_user, ...) and use the built-in variable ansible_user_id (which returns gitlab).

Additionally, I removed:

  • all the $ROLE/defaults files, to avoid duplication since we don't intend to use those roles as standalone.
  • setting the computer name, I think the default of "Gitlab's MacPro" is good enough
  • some leftover from multi-user mode, like accepting first-run prompts, since we do this on the single user when building the OS image

Why was this MR needed?

What's the best way to test this MR?

What are the relevant issue numbers?

Edited by Adrien Kohlbecker

Merge request reports