Skip to content

Add support for multiple subnets and security groups

R2D2 requested to merge r2d2/fargate:feature-multiple-sg-subnets into master

Closes #18 (closed)

This MR allows supplying multiple subnets and security groups.

  1. I'd strongly advise following MR being merged in first: !35 (merged) !39 (closed) !40 (closed) !41 (merged). Of course this MR would have to be rebased and re-worked.

  2. If this is the desired path, we will have to update this MR with Subnet => Subnets and SecurityGroup => SecurityGroups all over the place.

  3. @DanielCMiranda I'd like to hear your thoughts on this MR. I really like how you reorganized few things in !41 (merged). I'd also help if you can update test for current changes introduced in this MR (not step 2 yet - that's a bigger effort).

This MR will introduce breaking changes (singular -> plural) of Subnet and SecurityGroup parameters. Maintainers will have to take appropriate actions to notify users after the changes get merged.

Edited by R2D2

Merge request reports