Skip to content

Rely on `git ls-files` and `git diff` for checking mocks

Pedro Pombeiro requested to merge improve_check_mocks into master

What does this MR do?

This commit changes the check_mocks behaviour so that it guarantees that the existing commit matches the regenerated mocks. It also compares against the branch HEAD, in case some mock file is missing.

Why was this MR needed?

The existing check_mocks target isn't helpful in determining why a diff happens on the server and not on the client. It only compares the names of changed files instead of the actual contents.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#6 (closed)

Merge request reports