Skip to content

Rely on `git ls-files` and `git diff` for checking mocks

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge improve_check_mocks into master

What does this MR do?

This commit changes the check_mocks behaviour so that it guarantees that the existing commit matches the regenerated mocks. It also compares against the branch HEAD, in case some mock file is missing.

Why was this MR needed?

Some improvements were done in the other projects when bringing them up to date, so this backports those improvements.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#45 (closed), gitlab-org/gitlab-runner#25188 (closed)

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports