Add generic Data field to VM Instance for provider specific instance data (!155) · Merge requests · GitLab.org / Ops Sub-Department / custom-executor-drivers / Autoscaler - the Custom Executor driver · GitLab

You need to sign in or sign up before continuing.

Arran Walker requested to merge 90-vm-instance-data-field into master May 10, 2021

What does this MR do?

Adds a generic Data field to vm.Instance for additional underlying vm data.

Why was this MR needed?

Previously, it was specific to GCP. With the use of Orka and potentially other fields, it feels wrong to further introduce leaky abstractions.

What's the best way to test this MR?

This shouldn't really change anything, but I'm also not sure the best way to do a manual QA with the GCP provider.

What are the relevant issue numbers?

Closes #90 (closed)

Edited May 12, 2021 by Arran Walker