Skip to content

Vendor knative istio-metrics

João Alexandre Cunha requested to merge vendor-knative-metrics into master

This is part of gitlab-org/gitlab#202664 (closed)

I believe it's better to keep this vendored close to the chart which we use it with.

Plus, if we put it vendored as a code file on GitLab, we'd need to implement a weird construct like:

echo file_contents | kubectl apply -f -, which I think is a very specific implementation for only this case. Therefore, I'd prefer if it lives here then we can simply use kubectly apply -f final_url.

Pushing this file to a static server or pages seems a bit of overkill as well.

WDYT? @mattkasa

Merge request reports