Skip to content

Convert Gitaly port to an Integer before rendering in config files

Balasankar 'Balu' C requested to merge fix-gitaly-port-rendering into master

Cast global.gitaly.port to a String before using it in config files

Before this MR (note gitaly_address)

$ helm template . -x charts/gitlab/charts/unicorn/templates/configmap.yml --set global.ingress.configureCertmanager=false --set global.gitaly.host='my.random.website.com' --set global.gitaly.port=9999 | grep -C 4 repositories:
        enabled: false
      shared:
      gitaly:
        client_path: /home/git/gitaly/bin
        token: "<%= File.read('/etc/gitlab/gitaly/gitaly_token').strip.dump[1..-2] %>"
      repositories:
        storages: # You must have at least a `default` storage path.
          default:
            path: /var/opt/gitlab/repo
            gitaly_address: tcp://my.random.website.com:%!d(float64=9999)

After this MR

helm template . -x charts/gitlab/charts/unicorn/templates/configmap.yml --set global.ingress.configureCertmanager=false --set global.gitaly.host='my.random.website.com' --set global.gitaly.port=9999 | grep -C 4 repositories:
        enabled: false
      shared:
      gitaly:
        client_path: /home/git/gitaly/bin
        token: "<%= File.read('/etc/gitlab/gitaly/gitaly_token').strip.dump[1..-2] %>"
      repositories:
        storages: # You must have at least a `default` storage path.
          default:
            path: /var/opt/gitlab/repo
            gitaly_address: tcp://my.random.website.com:9999
Edited by Balasankar 'Balu' C

Merge request reports