Skip to content

removed kubernetes.io/ingress.class duplicate

Simon Ince requested to merge LUSHDigital/helm.gitlab.io:ingress-annotations-duplicate into master

I've removed kubernetes.io/ingress.class from both doc/example-config.yaml and charts/nginx/values.yaml as this is already set in charts/nginx/templates/ingress.yaml causing a conflict as this is being set multiple times.

This is one possible solution, another would be to remove the duplicate from the ingress.yaml and keep kubernetes.io/ingress.class as being set as an annotation in value files. A third option would be to make kubernetes.io/ingress.class a value in itself, and have something like:

  annotations:
    kubernetes.io/ingress.class: {{.Values.ingress.ingress-class }}

in the ingress file and then set it in the values files:

ingress:
  ingress-class: nginx

I'm not sure what would be best.

Merge request reports