Skip to content

Correct custom-instance-setup script invocation

Justin Farmiloe requested to merge jfarmiloe-custom-instance-setup-fix into master

What does this MR do?

The custom-instance-setup script was changed from a bash script to a ruby script in gitlab-org/build/CNG!590 (merged) but the instructions for manually running it as part of a restore of non-chart backup into a chart deployment were not updated to take account of this.

Result of currently documented command:

$ kubectl exec -it -n gitlab gitlab-task-runner-7959f4f89d-vrhrb -- /scripts/custom-instance-setup
Defaulted container "task-runner" out of: task-runner, certificates (init), configure (init)
Disabling authorized keys write in the database.
Traceback (most recent call last):
/scripts/custom-instance-setup:7:in `<main>': uninitialized constant ApplicationSetting (NameError)
command terminated with exit code 1

Result of proposed updated command:

$ kubectl exec -it -n gitlab gitlab-task-runner-7959f4f89d-vrhrb -- gitlab-rails runner -e production /scripts/custom-instance-setup
Defaulted container "task-runner" out of: task-runner, certificates (init), configure (init)
Disabling authorized keys write in the database.
Enabling incremental logging of CI jobs.
Disabling access to disk storage for GitLab Pages
Registering OAuth applications.

Author's checklist

To avoid having this MR be added to code verification QA issues, don't add these labels: ~"feature", frontend, backend, ~"bug", or database

Review checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
  • Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  • Ensure a release milestone is set.
Edited by Justin Farmiloe

Merge request reports