Skip to content

Set Workhorse shutdown to workerTimeout + 1 by default

Stan Hu requested to merge sh-workhorse-shutdown-default into master

This adds support for the shutdown_timeout config variable introduced in gitlab-org/gitlab!62701 (merged) to facilitate a graceful shutdown of Workhorse.

When Kubernetes issues a SIGTERM, Workhorse will kick all runners out of the long poll, shut down the HTTP server for new requests, and wait up to the shutdown_timeout interval for all current HTTP requests to complete before shutting down. By default, the Web application server can take up to 60 seconds to finish, we set the Workhorse timeout to 61 seconds.

Relates to gitlab-org/gitlab#325114 (closed)

Edited by Stan Hu

Merge request reports