Webservice: enable per-deployment blackoutSeconds
What does this MR do?
Webservice: enable per-deployment blackoutSeconds
Enable configuration of `shutdown.blackoutSeconds` on a per-deployment
basis by using environment variable that is populated into `gitlab.yml`
by the template at the time of execution.
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
[] Documentation created/updatedalready documented as inherited. Now employed. -
Tests added -
Integration tests added to GitLab QA
Closes #2543 (closed)
Merge request reports
Activity
changed milestone to %13.10
mentioned in issue #2543 (closed)
added 1 commit
- 25f2d05e - Webservice: enable per-deployment blackoutSeconds
1 Warning Please check the QA job and compare with builds on master. If no new failures are reported in QA job, add 'QA:verified' label. 1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review. If from a community member, ask that the Community contribution label be added as well.
Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersGenerated by
DangerEdited by 🤖 GitLab Bot 🤖requested review from @jarv
assigned to @WarheadsSE
- Resolved by Jason Plum
- Resolved by Jason Plum
- Resolved by DJ Mountney
@WarheadsSE is it better that we set the environment variable here or in settings https://gitlab.com/gitlab-org/gitlab/-/blob/7ff0058a15bbedce3657d5fd5b8b0d67bd2c8b68/config/initializers/1_settings.rb#L883 . I feel like putting it in settings is more consistent with other configuration, but I guess this works as well.
assigned to @jarv
removed review request for @jarv
added workflowin review label and removed workflowready for review label
assigned to @twk3 and unassigned @WarheadsSE and @jarv
- Resolved by Jason Plum
- Resolved by Jason Plum
- Resolved by Jason Plum
@WarheadsSE back to you with some feedback
assigned to @WarheadsSE and unassigned @twk3
- Resolved by Jason Plum
- Resolved by Jason Plum
added 1 commit
- 330c77a3 - Webservice: fixup gitlab.yml blackout_seconds env
requested review from @twk3
- Resolved by Jason Plum
assigned to @twk3 and unassigned @WarheadsSE
- Resolved by Jason Plum
I'll pull this back to me, so that I can investigate the pipeline issues later.
assigned to @WarheadsSE and unassigned @twk3
added 1 commit
- 9ba793ca - Webservice: simplify shutdown.blackout_seconds template
assigned to @twk3 and unassigned @WarheadsSE
mentioned in commit a8ba8bcf