Skip to content
Snippets Groups Projects

Webservice: enable per-deployment blackoutSeconds

Merged Jason Plum requested to merge 2543-blackout-per-deployment into master
All threads resolved!

What does this MR do?

Webservice: enable per-deployment blackoutSeconds

Enable configuration of `shutdown.blackoutSeconds` on a per-deployment
basis by using environment variable that is populated into `gitlab.yml`
by the template at the time of execution.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • [] Documentation created/updated already documented as inherited. Now employed.
  • Tests added
  • Integration tests added to GitLab QA

Closes #2543 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jason Plum
  • Jason Plum resolved all threads

    resolved all threads

  • Jason Plum added 1 commit

    added 1 commit

    • 6bbc5e7f - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • assigned to @jarv

  • John Jarvis resolved all threads

    resolved all threads

  • John Jarvis approved this merge request

    approved this merge request

  • LGTM

  • John Jarvis removed review request for @jarv

    removed review request for @jarv

  • Jason Plum assigned to @twk3 and unassigned @WarheadsSE and @jarv

    assigned to @twk3 and unassigned @WarheadsSE and @jarv

  • DJ Mountney
  • DJ Mountney
  • DJ Mountney
  • Contributor

    @WarheadsSE back to you with some feedback

  • DJ Mountney assigned to @WarheadsSE and unassigned @twk3

    assigned to @WarheadsSE and unassigned @twk3

  • Jason Plum
  • Jason Plum
  • Jason Plum added 1 commit

    added 1 commit

    • 9ba2346e - Apply 4 suggestion(s) to 2 file(s)

    Compare with previous version

  • Jason Plum added 1 commit

    added 1 commit

    • 330c77a3 - Webservice: fixup gitlab.yml blackout_seconds env

    Compare with previous version

  • Jason Plum requested review from @twk3

    requested review from @twk3

  • Jason Plum
  • Jason Plum added 1 commit

    added 1 commit

    • 9c30e784 - Add missing change to commits /facepalm

    Compare with previous version

  • Jason Plum assigned to @twk3 and unassigned @WarheadsSE

    assigned to @twk3 and unassigned @WarheadsSE

  • Jason Plum assigned to @WarheadsSE and unassigned @twk3

    assigned to @WarheadsSE and unassigned @twk3

  • Jason Plum added 1 commit

    added 1 commit

    • 9ba793ca - Webservice: simplify shutdown.blackout_seconds template

    Compare with previous version

  • Jason Plum assigned to @twk3 and unassigned @WarheadsSE

    assigned to @twk3 and unassigned @WarheadsSE

  • DJ Mountney resolved all threads

    resolved all threads

  • DJ Mountney approved this merge request

    approved this merge request

  • DJ Mountney mentioned in commit a8ba8bcf

    mentioned in commit a8ba8bcf

  • merged

  • Please register or sign in to reply
    Loading