Skip to content

Ensure global.redis.host is present if redis.install is false

Julius Kvedaras requested to merge redis-host-configuration into master

Adding configuration validation check for the global.redis.host if redis.install is false as the Redis host must be present and it is an invalid configuration

Test below:

juliuskvedaras@Juliuss-MBP:~/helm$ helm upgrade gitlab gitlab -f gitlab-dev/values.yaml 
Error: UPGRADE FAILED: template: gitlab/templates/NOTES.txt:55:3: executing "gitlab/templates/NOTES.txt" at <include "gitlab.checkConfig" .>: error calling include: template: gitlab/templates/_checkConfig.tpl:45:54: executing "gitlab.checkConfig" at <fail>: error calling fail: 
CONFIGURATION CHECKS:

redis:
  You've disabled the installation of Redis. When using an external Redis, you must populate `global.redis.host`. Please see https://docs.gitlab.com/charts/advanced/external-redis/

Closes #2087 (closed)

Edited by Ray Paik

Merge request reports