Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab Chart
GitLab Chart
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 495
    • Issues 495
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 33
    • Merge requests 33
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • charts
  • GitLab ChartGitLab Chart
  • Merge requests
  • !1287

Merged
Created Apr 15, 2020 by Jason Plum@WarheadsSE☕Maintainer2 of 2 tasks completed2/2 tasks

Allow configuring multiple Redis instances

  • Overview 67
  • Commits 14
  • Pipelines 13
  • Changes 21

From #1644 (closed)

Allow configuration of multiple Redis instances, for splitting persistence classes.

This implements the necessary configuration items, and templating of configuration and secrets.

Currently, it is expected that if this configuration is used, all Redis instances will be external to this Helm chart. This means that we expect redis.install to be false, and all necessary queues to be individuall configured under global.redis.

Side effects of this change:

  • ignorance of .Values.redis, in favor of .Values.global.redis
  • DRY-ification of resque.yml across all GitLab charts to a central template (gitlab.rails.redis.resque)
  • Secret mounting blocks are now rendered via gitlab.redis.secrets, which in turn consumes gitlab.redis.secret
  • Base implementation of ActionCable's cable.yml

Questions remaining:

  • Does gitlab/geo-logcursor need all of these configurations? ✅ It needs all / most.
  • Does gitlab/gitlab-exporter actually access Redis as configured? ✔ It needs the primary (as in resque.yml).

Documentation to be done: (Split out to #2027 (closed))

  • [ ] Add additional Redis properties to documentation
  • [ ] Move Redis configuration documentation out of Unicorn
  • [ ] Add documentation of multiple Redis to doc/advanced/external-redis

Closes #1644 (closed)

Edited Apr 17, 2020 by Jason Plum
Assignee
Assign to
Reviewer
Request review from
12.10
Milestone
12.10 (Past due)
Assign milestone
Time tracking
Source branch: 1644-support-multiple-redis