Skip to content

Deprecations: fix logic of registry hpa migration

Jason Plum requested to merge tpl-logic-error-registry-deprecation into master

Fix logic of registry replicas deprecation to be properly formatted for Sprig & gotpl/txt behaviors.

  • Bad: if A or B
  • Good: if or (A B)

Silently "worked" until go1.14, where we saw

can't give argument to non-function hasKey .Values.registry "minReplicas"
  • Worked: version.BuildInfo{Version:"v3.1.1", GitCommit:"afe70585407b420d0097d07b21c47dc511525ac8", GitTreeState:"clean", GoVersion:"go1.13.8"}
  • Failed: version.BuildInfo{Version:"v3.1.1", GitCommit:"afe70585407b420d0097d07b21c47dc511525ac8", GitTreeState:"clean", GoVersion:"go1.14"}

cc @tpresa

Merge request reports