gitlab-workhorse crashes with external redis and no password on 16.0.1
Summary
When upgrading from version 15.11.5
to 16.0.1
the gitlab-workhorse
came into a CrashLoopBackOff
. Therefor the new gitlab-webservices will not become healthy and the upgrade failed.
Steps to reproduce
- Run a gitlab instance on
15.x
with an external redis server without AUTH - Upgrade to
16.0.1
Configuration used
Example Values
global:
hosts:
externalIP: ********
domain: *****
ingress:
enabled: true
configureCertmanager: true
tls:
enabled: true
annotations:
"nginx.ingress.kubernetes.io/proxy-body-size": 0
## https://docs.gitlab.com/charts/advanced/external-db/
psql:
host: *****
port: *****
database: *****
username: *****
password:
secret: psql-credentials
key: password
ssl:
secret: psql-credentials
clientCertificate: tls.crt
clientKey: tls.key
serverCA: ca.crt
## https://docs.gitlab.com/charts/advanced/external-redis/
redis:
host: *****
port: *****
password:
enabled: false
## https://docs.gitlab.com/charts/advanced/external-object-storage/#backups
gitlab:
toolbox:
persistence:
enabled: true
storageClass: standard-rwo
accessMode: ReadWriteOnce
size: 256Gi
## https://docs.gitlab.com/charts/advanced/external-db/
postgresql:
install: false
## https://docs.gitlab.com/charts/advanced/external-redis/
redis:
install: false
certmanager-issuer:
email: ********@******.com
gitlab-runner:
install: false
Current behavior
Gitlab helm state became failed.
Expected behavior
Successful upgrade to 16.0.1
Versions
- Chart:
7.0.1
- Platform:
- Cloud: GKE
- Self-hosted: -
- Kubernetes: (
kubectl version
)- Client:
v1.24.13-dispatcher
- Server:
v1.24.11-gke.1000
- Client:
- Helm: (
helm version
)- Client:
v3.9.4
- Server: -
- Client:
Relevant logs
failed to render template /var/opt/gitlab/templates/workhorse-config.toml.tpl: template: /var/opt/gitlab/templates/workhorse-config.toml.tpl:4:18: executing "/var/opt/gitlab/templates/workhorse-config.toml.tpl" at <file.Read>: error calling Read: failed to open /etc/gitlab/redis/redis-password: open /etc/gitlab/redis/redis-password: no such file or directory
Workaround
This bug is fixed, but still present in chart versions 7.0
(GitLab %16.0 ) and 7.0.1
(GitLab 16.0.1)
See this comment for the workaround until the next patch release.