gitlab-toolbox-backup does not support group_saml omniauth provider
Summary
gitlab-toolbox-backup does not support group_saml omniauth provider : when a secret is defined and contains only name: 'group-saml'
and is used in the omniauth providers list, gitlab-toolbox-backup crashes.
Steps to reproduce
-
Define the special omniauth provider "group_saml" that does require only
name: 'group-saml'
in the secret definition to activate the fonctionnality (source : https://docs.gitlab.com/ee/integration/saml.html#configuring-group-saml-on-a-self-managed-gitlab-instance ) -
apply the new config of the helm chart
-
gitlab works fine, gitlab UI does have the saml group feature, but the secret broke gitlab-toolbox-backup and we got this error (gitlab-saml-group is the name of the secret) : /usr/lib/ruby/2.7.0/psych.rb:577:in `initialize': No such file or directory @ rb_sysopen - /etc/gitlab/omniauth/gitlab-saml-group/provider (Errno::ENOENT)
And this is not because I broke something : there is no provider section in this secret, according to the docs, and the group saml feature works fine in the UI. I guess that gitlab-toolbox-backup tries to access everything but the presence of the "provider" section seems hardcoded ?
Configuration used
(I deleted the config of our others saml providers, because it did not seems to be the issue.
omniauth:
enabled: true
providers:
- secret: gitlab-saml-group
# kubernetes secret "gitlab-saml-group":
---
name: 'group-saml'
Current behavior
gitlab works fine, gitlab UI does have the saml group feature, but the secret broke gitlab-toolbox-backup and we got this error (gitlab-saml-group is the name of the secret) :
/usr/lib/ruby/2.7.0/psych.rb:577:in `initialize': No such file or directory @ rb_sysopen - /etc/gitlab/omniauth/gitlab-saml-group/provider (Errno::ENOENT)
Expected behavior
gitlab-toolbox-backup shouldn't fail in trying to access tries to access /etc/gitlab/omniauth/gitlab-saml-group/provider
Versions
- Chart: 5.6.0
- Platform:
- Cloud: EKS
- Kubernetes: (
kubectl version
)- Client: v1.22.4
- Server: v1.20.11-eks-f17b81
- Helm: (
helm version
)- Client: v3.6.3
- Server: v3.6.3
Relevant logs
gitlab-toolbox-backup logs :
/usr/lib/ruby/2.7.0/psych.rb:577:in `initialize': No such file or directory @ rb_sysopen - /etc/gitlab/omniauth/gitlab-saml-group/provider (Errno::ENOENT)