Gitaly concurrency config is bound to GitLab Shell configuration
Summary
Noticed in reviewing !1308 (merged), the current concurrency
settings for Gitaly configuration are nested under the shell
properties, leaving that configuration bound to the use of GitLab Shell configuration. From all appearances, this is incorrect. Based on Omnibus GitLab's gitaly-config.toml.erb
and Gitaly's own documentation, this is an item that should be present as a top-level chart property and mapped into the config.toml
as such.
Steps to reproduce
Read https://docs.gitlab.com/ee/administration/gitaly/reference.html#concurrency. Attempt to find documentation of these settings in docs/charts/gitlab/gitaly
, find none (#2077 (closed)), and then read the values.yaml
for the chart. Find shell.concurrency
Configuration used
gitlab:
gitaly:
concurrency:
- rpc: "/gitaly.SmartHTTPService/PostUploadPack"
maxPerRepo: 20
- rpc: "/gitaly.SSHService/SSHUploadPack"
maxPerRepo: 5
Current behavior
Expected behavior
[[concurrency]]
rpc = "/gitaly.SmartHTTPService/PostUploadPack"
max_per_repo = 20
[[concurrency]]
rpc = "/gitaly.SSHService/SSHUploadPack"
max_per_repo = 5
Versions
- Chart: b4cad9cf