Operator doesn't wait for gitaly to rollout
Summary
Observed during the past two weekly cloud native demos. The operator is considering gitaly rolled, and continues while we can clearly see from kubectl and from the google console that the gitaly pod has not been started.
Likely the checkStatefulSetFinished
code needs to be updated, similar to how we updated the deployment check, with the same code that is used upstream for checking rollouts: https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/statefulset/stateful_set_utils.go#L375 (see the completeRollingUpdate
method here)