Skip to content

Add tls option in smtp settings for ActionMailer

Summary

There is no tls option support in smtp settings for ActionMailer template, so ActionMailer doesn't work with Yandex. Patching smtp_settings.rb with tls: true option leads to success

Steps to reproduce

Use Yandex as smtp service

Configuration used

According to https://docs.gitlab.com/omnibus/settings/smtp.html#yandex

global:
  smtp:
    enabled: true
    address: smtp.yandex.ru
    port: 465
    user_name: my-user-name
    domain: yandex.ru
    authentication: login
    starttls_auto: true
    openssl_verify_mode: peer
    password:
      secret: gitlab-smtp-password

Current behavior

ActionMailer template has no tls option

Expected behavior

--set global.smtp.tls=true

Versions

  • Chart: 1.4.4
  • Platform:
    • Self-hosted: Kubespray
  • Kubernetes:
    • Client: v1.13.1
    • Server: v1.12.3
  • Helm:
    • Client: v2.9.1
    • Server: v2.11.0