Skip to content

don't mount token when tokens not set

Reinier Schoof requested to merge (removed):fix-token-secret into main

What does this MR do?

When neither the runner registration token nor the runner token is set, the Secret usually containing them is not templated. It is however still mounted in the Deployment's projected secret. This MR fixes that.

Why was this MR needed?

I'm trying to mount the registration token myself from an externally managed secret and despite the fact that the Secret disappears, it is still mounted in the Deployment. This prevents me from deploying the Helm chart without runnerRegistrationToken set.

What's the best way to test this MR?

Try to deploy the chart without the runnerRegistrationToken set. This will leave the gitlab-runner Pod pending because it can't find the Secret.

What are the relevant issue numbers?

Couldn't find any.

Merge request reports