Skip to content

Make session server service annotations configurable

Matthias Baur requested to merge syseleven/helm-charts/gitlab-runner:session-server-service-annotations into main

What does this MR do?

Make session server service annotations configurable

Why was this MR needed?

Our LBaaS uses annontations for custom floating IP allocations:

kind: Service
metadata:
  annotations:
    loadbalancer.openstack.org/floating-network-id: 1234567890-3654-8985-3333-111111111

What's the best way to test this MR?

$ helm template gitlab-runner -s templates/service-session-server.yaml . --set sessionServer.enabled=true --set sessionServer.serviceAnnotations.foo=bar
---
# Source: gitlab-runner/templates/service-session-server.yaml
apiVersion: v1
kind: Service
metadata:
  name: gitlab-runner-gitlab-runner-session-server
  annotations:
    foo: "bar"
  labels:
    app: gitlab-runner-gitlab-runner
    chart: gitlab-runner-0.38.0-beta
    release: "gitlab-runner"
    heritage: "Helm"
  namespace: "gitlab-runner"
spec:
  selector:
    app: gitlab-runner-gitlab-runner
    release: "gitlab-runner"
  type: LoadBalancer
  ports:
  - protocol: TCP
    port: 9000
    targetPort: 8093

What are the relevant issue numbers?

Edited by Matthias Baur

Merge request reports