Skip to content

Add possibility to overwrite default image registry

Alexander Lauster requested to merge computeralex92/gitlab-runner:add-registry-overwrite into main

What does this MR do?

Add support to overwrite the default container image registry

Why was this MR needed?

If you want to use e.g. the images stored at the AWS Public ECR, you need currently to specifier the image manually.

This cause the issue to upgrade the helm chart version in the upgrade process of Gitlab, but you need to upgrade also the version of the used image.

With this overwrite, the default version logic implemented in the chart is still usable; the manual step decribed above is not needed anymore.

What's the best way to test this MR?

  1. Run helm install --dry-run --debug to see if the image registry is changing when changing the value in the values.yaml
  2. Install the runner with the changed chart and test if everything is still working

What are the relevant issue numbers?

Edited by Alexander Lauster

Merge request reports