Skip to content

Only add environment variables if values set

Matthew Warman requested to merge mcwarman/gitlab-runner:conditonal-env-vars into main

What does this MR do?

Wraps environment variables being set on the deployment with conditions, which was causing values set in the runners.config to be overridden.

Why was this MR needed?

Allow template users to move away from needing to set deprecated values.

What's the best way to test this MR?

helm install -n tooling gitlab-runner -f test-values.yaml  .
# test-values.yaml 
gitlabUrl: https://gitlab.***
runnerRegistrationToken: ***

runners:
  config: |
    [[runners]]
      [runners.kubernetes]
        namespace = "runners"
        image = "ubuntu:16.04"
        pull_policy = ["always"]

With changes:

# /home/gitlab-runner/.gitlab-runner/config.toml 
[[runners]]
# ...
  [runners.kubernetes]
    image = "ubuntu:16.04"
    namespace = "runners"
    pull_policy = ["always"]

Without changes:

# /home/gitlab-runner/.gitlab-runner/config.toml 
[[runners]]
# ...
  [runners.kubernetes]
    image = "ubuntu:16.04"
    namespace = "tooling"
    pull_policy = [""]

What are the relevant issue numbers?

Fixes #274 (closed)

Merge request reports