template-config.toml and config.toml - Useful chart infrastructure
If we want to solve #82 (closed), we may need to configure some settings that requires the use of the --template-config
flag and a template-config.toml file.
UPDATE:
- I realize I have planned this on the existence of a fromToml function that did not exist. I need to rethink this PR.
- I'm closing this in favor of effort into !169 (closed) regarding formatting and documentation, and !153 (closed) regarding the --template-config support.
This PR does the following
- Increase consistency of YAML formatting with current in chart practices and started to adopt practices in the templates from
helm create
, such as usingnindent
overindent
to allow for more readable templates. - Added inline comments about scripts created in the configmap to summarize their purpose.
- Added support for configuring .Values.runners."template-config.toml"
- Added support for configuring .Values."config.toml"
Please review this
- PR splitting: If you need me to split this PR into multiple focused ones, I could, and would do it like this:
- Should we avoid the
.
in the key's? I chose to use it in for example config.toml as a key value as it is more descriptive and easy to understand directly than for example configToml, but it becomes a bit harder to reference it from the helm templates. - Does the descriptions make sense?
- Is there additional documentation to add?
Edited by Erik Sundell