Bug: secretName in Ingress extension is wrongly indented
From my personal testing, the current indentation of secretName
in the ingress.yaml
is wrong.
As it is now, accessing a deployment via https
returns a default backend - 404
; simply changing the indentation -as shown below- fixes the routing to the application.
the current helm chart indentation:
tls:
- hosts:
{{- if .Values.service.commonName }}
- {{ template "hostname" .Values.service.commonName }}
{{- end }}
- {{ template "hostname" .Values.service.url }}
{{- if .Values.service.additionalHosts }}
{{- range $host := .Values.service.additionalHosts }}
- {{ $host }}
{{- end -}}
{{- end }}
secretName: {{ .Values.ingress.tls.secretName | default (printf "%s-tls" (include "fullname" .)) }}
Causes the final compiled result to look like this:
tls:
- hosts:
- ${Host}
secretName: ${secret name}
Whereas it should be:
tls:
- hosts:
- ${Host}
- secretName: ${secret name}
I am happy to submit an MR if this is confirmed.
Thanks
Edited by melkar