Skip to content
Snippets Groups Projects

Introduce abstract class Action to handle classify or proxy

Merged Lin Jen-Shin requested to merge rule-action into main
All threads resolved!

This way we only need to cast the rule to the right action type, then we can call methods on those objects instead of having switch case everywhere we need to know which rule or action we're dealing with.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lin Jen-Shin
  • Lin Jen-Shin added 1 commit

    added 1 commit

    • b9469c4d - Introduce abstract class Action to handle classify or proxy

    Compare with previous version

  • Lin Jen-Shin added 1 commit

    added 1 commit

    • 17bead7c - Introduce abstract class Action to handle classify or proxy

    Compare with previous version

  • Lin Jen-Shin
  • Lin Jen-Shin requested review from @bmarjanovic

    requested review from @bmarjanovic

  • Lin Jen-Shin changed milestone to %17.4

    changed milestone to %17.4

  • Bojan Marjanovic
  • Bojan Marjanovic
  • Bojan Marjanovic
  • Lin Jen-Shin added 1 commit

    added 1 commit

    • 3ece99fc - Introduce abstract class Action to handle classify or proxy

    Compare with previous version

  • Lin Jen-Shin added 3 commits

    added 3 commits

    • 37445d98 - Refactorings to prepare to add a Logger
    • d87058b1 - Update dependency wrangler to ^3.72.3
    • f032f305 - Introduce abstract class Action to handle classify or proxy

    Compare with previous version

  • Lin Jen-Shin changed target branch from main to extract-rules-matching-into-router-engine

    changed target branch from main to extract-rules-matching-into-router-engine

  • I resolved the conflicts from !217 (merged) and set that as the target branch to show the actual diff. After that's merged, the target branch should be switched back to main automatically.

  • Lin Jen-Shin added 1 commit

    added 1 commit

    • 4c2076c7 - Introduce abstract class Action to handle classify or proxy

    Compare with previous version

  • Lin Jen-Shin added 1 commit

    added 1 commit

    • c30a0415 - Introduce abstract class Action to handle classify or proxy

    Compare with previous version

  • Lin Jen-Shin added 1 commit

    added 1 commit

    • 65737afa - Introduce abstract class Action to handle classify or proxy

    Compare with previous version

  • requested review from @OmarQunsulGitlab

  • Omar Qunsul deleted the extract-rules-matching-into-router-engine branch. This merge request now targets the main branch

    deleted the extract-rules-matching-into-router-engine branch. This merge request now targets the main branch

  • Lin Jen-Shin added 14 commits

    added 14 commits

    Compare with previous version

  • Lin Jen-Shin added 1 commit

    added 1 commit

    • 6400b6f1 - Introduce abstract class Action to handle classify or proxy

    Compare with previous version

  • Omar Qunsul approved this merge request

    approved this merge request

  • Omar Qunsul removed review request for @OmarQunsulGitlab

    removed review request for @OmarQunsulGitlab

  • Bojan Marjanovic approved this merge request

    approved this merge request

  • Bojan Marjanovic resolved all threads

    resolved all threads

  • mentioned in commit bb158458

  • Bojan Marjanovic resolved all threads

    resolved all threads

  • Lin Jen-Shin mentioned in merge request !230 (merged)

    mentioned in merge request !230 (merged)

  • mentioned in epic gitlab-org#14509

  • Please register or sign in to reply
    Loading