Introduce abstract class Action to handle classify or proxy
This way we only need to cast the rule to the right action type, then we can call methods on those objects instead of having switch case everywhere we need to know which rule or action we're dealing with.
Merge request reports
Activity
assigned to @godfat-gitlab
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@godfat-gitlab
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
added maintenancerefactor label
added typemaintenance label
added 1 commit
- b9469c4d - Introduce abstract class Action to handle classify or proxy
added 1 commit
- 17bead7c - Introduce abstract class Action to handle classify or proxy
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Bojan Marjanovic
@bmarjanovic Please review? Thanks!
requested review from @bmarjanovic
changed milestone to %17.4
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
- Resolved by Lin Jen-Shin
added 1 commit
- 3ece99fc - Introduce abstract class Action to handle classify or proxy
added Engineering Productivity label
I resolved the conflicts from !217 (merged) and set that as the target branch to show the actual diff. After that's merged, the target branch should be switched back to
main
automatically.added 1 commit
- 4c2076c7 - Introduce abstract class Action to handle classify or proxy
added 1 commit
- c30a0415 - Introduce abstract class Action to handle classify or proxy
added 1 commit
- 65737afa - Introduce abstract class Action to handle classify or proxy
requested review from @OmarQunsulGitlab
added 14 commits
-
65737afa...bda080ec - 12 commits from branch
main
- d3a40147 - Refactorings to prepare to add a Logger
- 8e7597c3 - Introduce abstract class Action to handle classify or proxy
-
65737afa...bda080ec - 12 commits from branch
added 1 commit
- 6400b6f1 - Introduce abstract class Action to handle classify or proxy
removed review request for @OmarQunsulGitlab
mentioned in commit bb158458
- Resolved by Bojan Marjanovic
A pipeline is running on a mirror related to this merge request.
Status: starting
https://ops.gitlab.net/gitlab-org/cells/http-router/-/pipelines/3667710
mentioned in merge request !230 (merged)
mentioned in epic gitlab-org#14509
mentioned in epic gitlab-org&14509
mentioned in epic gitlab-org&12383
mentioned in issue gitlab-com/gl-infra/tenant-scale/cells-infrastructure/team#146 (closed)