(1st MR) Refactorings to prepare to add a Logger

Preparing for: https://gitlab.com/gitlab-org/cells/http-router/-/issues/18

This was extracted from the (2nd MR) !205 (merged)

Context in this conversation: !205 (comment 2078617851)

What has been done in this MR?

1. .gitignoreing wrangler.toml because it's generated by GDK, which makes it show up in the git diff. The original file content has been copied to wrangler.toml.example instead.
2. Moving all the classify logic into classify.ts
3. Moving the main rules matching into a new class RouterEngine that can encapsulate all the logic of rules matching and applying the matching rule. And keeping the main part of the Router minimal export default.
4. Adding unique ID to the rules, so that we log which rule has been matched. Maybe we can add a validation that the IDs of the rules are unique in a follow up issue?
5. Refactor the Documentation. Moved the development into its own page and added Blueprint relevant pages.

Validate changes

On both values GITLAB_RULES_CONFIG=passthrough & GITLAB_RULES_CONFIG=firstcell in your wrangler.toml in env.dev section, the Router should still forward requests to the GitLab instance. By visiting http://gdk.test:3000 you should still see GitLab running.

assigned to @OmarQunsulGitlab

added 1 commit

• 7b922e10 - Refactorings to prepare to add a Logger

Compare with previous version

Proper labels assigned to this merge request. Please ignore me.

@OmarQunsulGitlab - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

added Category:Cell label

added devopsdata stores grouptenant scale sectioncore platform labels

changed milestone to %17.4

added maintenancerefactor label

added typemaintenance label

changed title from Draft: Refactorings to prepare to add a Logger to Draft: (1st MR) Refactorings to prepare to add a Logger

changed the description

resolved all threads

changed the description

added 1 commit

• 22b74834 - Refactorings to prepare to add a Logger

Compare with previous version

changed the description

requested review from @bmarjanovic

marked this merge request as ready

mentioned in merge request !205 (merged)

@bmarjanovic as you suggested here, I have extracted the changes not related to the Logger in this MR.

I suggest that you can see the final version of index.ts, because it might give you an idea how it would look like if this MR is merged.

added 1 commit

• 37445d98 - Refactorings to prepare to add a Logger

Compare with previous version

approved this merge request

requested review from @tkuah and removed review request for @bmarjanovic

mentioned in merge request !218 (merged)

Thanks @OmarQunsulGitlab - I only have one question / concern

removed review request for @tkuah

mentioned in merge request gitlab-com/gl-infra/cells/http-router-deployer!9 (closed)

mentioned in merge request !225 (closed)

added 12 commits

• 37445d98...94459410 - 11 commits from branch main
• 996ca581 - Refactorings to prepare to add a Logger

Compare with previous version

added 1 commit

• 32d706ea - Undo .gitignor-ing wrangler.toml

Compare with previous version

reset approvals from @bmarjanovic by pushing to the branch

added 1 commit

• 8888e532 - Undo .gitignor-ing wrangler.toml

Compare with previous version

requested review from @bmarjanovic

approved this merge request

resolved all threads

merged

mentioned in commit bda080ec

A pipeline is running on a mirror related to this merge request.

Status: starting

https://ops.gitlab.net/gitlab-org/cells/http-router/-/pipelines/3665182

resolved all threads

mentioned in merge request !230 (merged)

mentioned in merge request gitlab-org/gitlab-development-kit!4001 (merged)

mentioned in merge request !233 (merged)

added devopstenant scale groupcells infrastructure sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels