Skip to content

Fixed checking bash array for 0 length in release-helper.sh

Gerard Hickey requested to merge fix/release-helper-error into master

In looking at the build-test CI job, I found the following output:

+ local resources
+ '[' -z gitlab-sidekiq-ee.tar.gz gitlab-python.tar.gz gitlab-logger.tar.gz ']'
./release-helper.sh: line 155: [: too many arguments
+ echo 'resources: '
+ for resource in "${resources[@]}"
+ appendResourceToManifest gitlab-sidekiq-ee.tar.gz ./repo1/gitlab-sidekiq

It actually appears that the correct code for the if statement was actually running. In other words an error that produced the correct results, although I would have really like to have seen the error kill the script.

Merge request reports