Refactor GitLab KAS
Hi @WarheadsSE!
I took a look at gitlab-org/charts/gitlab#3208 (moved), and given I am interested in the topic, I tried to tackle gitlab-kas
, which is small and (I hope) easy.
In this way, I aim to understand better what are the exact goals of the issue, and how I can contribute.
Foremost, any general feedback is welcome: I tried to take a look at the other images in the project to put together all the best practices you are following, kindly let me know if I hit the target.
I have also some questions:
- do we want to use
gitlab-fetch
only for UBI, or for all images? - based on the answer above, where should we invoke
gitlab-fetch
? If it is only for UBI, I think independencies.ubi8
(this is what I did)? - if we don't use gitlab-fetch for the “standard” Docker image, where we should put the git clone step? Shall we create a wrapper for this clone step?
- how do you prefer receiving my contributions? One MR per project, or one MR with all the containers? I would prefer the former, so I can proceed in baby steps during my spare time, and receive feedback, but please let me know what you prefer
- I would like to try to standardize naming in my contributions: do you prefer verbose variables or not (
GITLAB_NAMESPACE
orNAMESPACE
?) - Shall I focus on UBI8, or on both images for each project?
As a side note, I also took a look to the CI, and I feel your pain now!
Thanks, and have a great weekend :-) R.