Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C CNG
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GitLab.orgGitLab.org
  • Build
  • CNG
  • Merge requests
  • !981

Add FIPS pipeline

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vishal Tak requested to merge vtak-sh-build-workhorse-fips into master Apr 20, 2022
  • Overview 51
  • Commits 1
  • Pipelines 51
  • Changes 11

What does this MR do?

As part of being FIPS compliant, we need docker images of go/gitlab-pages/other components which are FIPS compliant.

Initial approach was to have separate images for fips variant. e.g.

  • gitlab-go-fips - Installs go that uses FIPS compliant crypto functions
  • gitlab-pages-fips - Installs Pages using gitlab-go-fips

However, most of the code for gitlab-pages-fips is very similar to gitlab-pages. It would become more of a maintenance problem going forward. Based on the discussion , @stanhu made changes in !976 (closed) to have a FIPS pipeline similar to UBI pipeline. This MR builds up on top of that to mainly add support for multiple openshift.metadata files based on the type of pipeline

Summary of changes

  • Add support for FIPS pipeline
  • Add support for multiple openshift.metadata files with backwards compatability
    • For FIPS pipelines, it will try to read first from openshift.metadata.fips. If that is not available, it will fall back to openshift.metadata
    • For UBI pipelines, it will try to read first from openshift.metadata.ubi8. If that is not available, it will fall back to openshift.metadata

Related issues

  • gitlab-org/gitlab-pages#716 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited May 19, 2022 by Jason Plum
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: vtak-sh-build-workhorse-fips