refactor(registry): CMD use exec form
What does this MR do?
What
- Update the
CMD
fo the gitlab-container-registry image to be inexec form
using the array notation rather then the shell form. - Move the command into a shell script so variable expanstion works, because if we
put in the
CMD
array it will not be expanded.
Why
In gitlab-org/charts/gitlab#3249 (closed) we are
going through all the images that have CMD
defined and updating it to
be from CMD command
(shell form) to CMD ["executable"]
(exec form)
so that we are consistent and the main process is always PID 1 so the
main process gets the termination signal.
Related issues
Reference: gitlab-org/charts/gitlab#3249 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Integration tests added to GitLab QA -
The impact any change in container size has should be evaluated
Edited by Steve Xuereb