Skip to content

fix(gitlab-pages): graceful termination

Steve Xuereb requested to merge fix/gitlab-pages into master

What does this MR do?

What

Move the gitlab-pages process to be PID 1 inside of the container by using exec in start up script and CMD in exec form as well.

Why

In gitlab-org/charts/gitlab#3249 (closed) we found out that most images we build their main process doesn't run as PID 1. This can lead to issues where we assume SIGTERM is being sent to the process but it isn't, it's sent to the bash script that starts the the process which doesn't redirect the signal to the gitlab-pages process.

Related issues

Reference: gitlab-org/charts/gitlab#3249 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Jason Plum

Merge request reports