Skip to content

Cleanup temp directories before creating backups

Priyan Sureshbabu requested to merge charts_issue_3041 into master

What does this MR do?

If there exists old directories lying around in /srv/gitlab/tmp/backups which are part of previous failed backup attempts, backup-utility will pack up those with the current backup tarball. This makes the backup tarball unreliable and restoring from that might break the entire GitLab instance.

This MR cleans up temp directories before the tarball is packed up.

Related issues

Closes: gitlab-org/charts/gitlab#3041 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Priyan Sureshbabu

Merge request reports