Skip to content

Explicitly wait on the PID instead of a pgrep search

John Skarbek requested to merge jts/shell-healthcheck-ponderance into master

What does this MR do?

This switches from a process search using pgrep to using the pid file that sshd is currently configured to write. Should the sshd process fail for any reason, we'll begin to fail the healthcheck. Where-as, for long running ssh client connections, if sshd were to die, we'd still match the pgrep, passing the healthcheck, but new connections inbound to the Pod will die with an error. Let's fail the healthcheck to signal to Kubernetes that this Pod needs a restart.

Related issues

Addresses: gitlab-org/charts/gitlab#2357 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by John Skarbek

Merge request reports