Install tzdata and tzdata-legacy in gitlab-base

Jason Plumrequested to merge
duo/fix/3114-tzdata-backport-to-19-4 into 19-4-stable

What does this MR do and why?

This backports !3114 (merged) (squashed commit e67fea200a50295533f61a957806ca406f047fa4, cherry-picked cleanly with no conflicts) to 19-4-stable.

Debian trixie split legacy IANA timezone names (for example Israel, Europe/Kiev, US/Eastern, Asia/Calcutta) out of tzdata into a separate tzdata-legacy package. The 19.4 trixie upgrade (!3052 (merged)) added tzdata-legacy to the gitlab-rails image but not gitaly. Gitaly's Go runtime resolves timezones with time.LoadLocation against system zoneinfo files, so without tzdata-legacy it fails with unknown time zone for any legacy name, which GitLab Rails surfaces as a false merge conflict for users whose profile timezone is a legacy name.

This is a regression introduced in 19.4 by the trixie upgrade, so the fix is needed on the 19-4-stable branch.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The original MR has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Merge request reports