Skip to content

Fix greedy suffix match

Dmytro Makovey requested to merge dm-fix-greedy-match into master

What does this MR do?

As discussed in slack thread - this is to fix greedy suffix match that was breaking builds in dev as we use port number in container URIs.

given image URI from dev

a="dev.gitlab.org:5005/gitlab/charts/components/images/kubectl:f94bda208353795e181c382a98e136cb63eebfce-buildx"

present code extracts

$ echo ${a%%:*}
dev.gitlab.org

as image_name whereas in reality it should be:

$ echo ${a%:*}
dev.gitlab.org:5005/gitlab/charts/components/images/kubectl

sample failing pipeline: https://dev.gitlab.org/gitlab/charts/components/images/-/pipelines/334530

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Jason Plum

Merge request reports