Skip to content

Actually use go-fips version variables

Ryan Egesdahl requested to merge add-go-build-args-fips into master

What does this MR do?

Actually use go-fips version variables

Because GO_FIPS_VERSION and GO_FIPS_TAG weren't being set during the
container build, the default version was in use. We only detected this
once we tried to upgrade Go and got the old version. This should
ensure that the gitlab-go container is rebuilt whenever a new go-fips
version is released.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Robert Marshall

Merge request reports