Remove Sidekiq queue selector and negate options

What does this MR do?

Remove Sidekiq queue selector and negate options

Announcement for 17.0 removal: https://docs.gitlab.com/ee/update/deprecations.html#queue-selector-for-running-sidekiq-is-deprecated

Related issues

Removal issue: gitlab-com/gl-infra/scalability#2220

Charts removal MR: gitlab-org/charts/gitlab!3697 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

• Merge Request Title, and Description are up to date, accurate, and descriptive
• MR targeting the appropriate branch
• MR has a green pipeline on GitLab.com
• When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes
• Documentation created/updated
• Integration tests added to GitLab QA
• The impact any change in container size has should be evaluated
• New dependencies are managed with dependencies.io

changed milestone to %17.0

assigned to @marcogreg

marked the checklist item Merge Request Title, and Description are up to date, accurate, and descriptive as completed

1 Message

Please add the workflowready for review label once you think the MR is ready to for an initial review. If from a community member, ask that the Community contribution label be added as well. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO. If you don't receive a response, please mention @gitlab-org/distribution, or one of our Project Maintainers

Generated by Danger

added 1 commit

• 0da88722 - Remove Sidekiq queue selector and negate options

Compare with previous version

marked the checklist item MR targeting the appropriate branch as completed

added maintenanceremoval typemaintenance labels

added 1 commit

• 1d366d14 - Remove Sidekiq queue selector and negate options

Compare with previous version

added devopssystems groupdistribution group::distributionbuild labels

added sectioncore platform label

added group::distributiondeploy label and removed group::distributionbuild label

marked the checklist item MR has a green pipeline on GitLab.com as completed

marked the checklist item When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow as completed

added workflowready for review label

changed the description

@gitlab-org/distribution Hi team, is anyone available to do an initial review for this MR please?

Pinging the group as per Danger's bot suggestion in !1798 (comment 1867044580). Sorry for the noise!

added workflowin review label and removed workflowready for review label

requested review from @clemensbeck

resolved all threads

approved this merge request

LGTM. Thanks @marcogreg .

• Deprecation was announced in https://docs.gitlab.com/ee/update/deprecations.html#queue-selector-for-running-sidekiq-is-deprecated
• The charts MR (gitlab-org/charts/gitlab!3697 (merged)) has already been merged. Therefore, the SIDEKIQ_NEGATE_QUEUES and SIDEKIQ_QUEUE_SELECTOR variables should no longer be populated to this process wrapper.
• Charts pipeline passes: https://gitlab.com/gitlab-org/charts/gitlab/-/pipelines/1273304548

requested review from @WarheadsSE

approved this merge request

merged

mentioned in commit bbb713ec

mentioned in issue gitlab-com/gl-infra/scalability#2220