Skip to content

Reduce rake calls in geo-db-migrate

Ian Baum requested to merge reduce-geo-migration-steps into master

What does this MR do?

Reduce rake calls in geo-db-migrate

  • Stops doing a check of the database schema version, as a similar check is already part of the db:schema:load:geo task. Should reduce the initial load of the database, and reduce a potential race condition where migrations can be run while this is running.

Changelog: changed

Related issues

gitlab-org/gitlab#430132 (closed)

Test plan

  1. With a Cloud Native hybrid Geo secondary instance configure the toolbox deployment to use the gitlab-rails image from this branch
  2. With an empty tracking database, ensure the geo-db-migrate script runs the db:schema:load:geo without error
  3. With some or all migrations applied to a tracking datgabase, ensure the geo-db-migrate catches an error running the db:schema:load:geo rake task, and then runs the db:migrate:geo rake task

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Jason Plum

Merge request reports