Skip to content

Fix deps io replace for rubygems and bundler

Clemens Beck requested to merge bundler-rubygems-deps-io into master

What does this MR do?

Fix deps io replace for rubygems and bundler

Deps io collects the latest tag for each `replace_in_files` but only the
last result is kept. Because of this all rubygems/bundler versions are
replaced with one version.

This workaround only looks for the minor version of rubygems and
replaces all rubygems/bundler versions with it. The major version has
been moved to the replace pattern.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
    1. Clone CNG
    2. Checkout this branch
    3. Remove the git remote (to trick deps into not recognizing existing MRs as an outdated update)
    4. Update the bundler/rubygems versions to an older version
    5. Run deps upgrade -v
    6. Confirm the rubygems and bundler version are updated to 2.4.22/3.4.22
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Clemens Beck

Merge request reports