Skip to content

Change default Gitaly config template from erb to tpl

Clemens Beck requested to merge gitaly-bundle-tpl-config-file into master

What does this MR do?

Change default Gitaly config template from erb to tpl

With https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1584
merged, the Gitaly image is no longer based on a Ruby base image, so
erb config templates not being parsed anymore.

Downstream consumers (GitLab Helm chart and GitLab Operator) use tpl
config files, so we can safely migrate from erb to tpl.

Chagelog: fixed
Relates: https://gitlab.com/gitlab-org/gitlab-shell/-/issues/688

Closes: main branch pipeline failing due to problem wit... (gitlab-org/gitlab-shell#688 - closed)

Related issues

Relates: gitlab-org/gitlab-shell#688 (closed)

Relates #524 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Ash McKenzie

Merge request reports