Skip to content

Consolidate Puma low-level error handler code

Stan Hu requested to merge sh-consolidate-puma-low-level-handler into master

What does this MR do?

Previously the Puma low-level error handler was specified in three different places (Cloud Native GitLab, Omnibus GitLab, GitLab Development Kit). Any time a change was needed we would have to update three different files. We can simplify this by using a central class that each of the configuration files can use.

This change requires gitlab-org/gitlab!132581 (merged).

Omnibus GitLab merge request: gitlab-org/omnibus-gitlab!7212 (merged)

Related issues

Relates to gitlab-org/gitlab#426135 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Jason Plum

Merge request reports